Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers with 'isFullExtent' constraint cause layers with lower draw order to endlessly request redraws #240

Open
pdille opened this issue Oct 28, 2021 · 0 comments
Assignees

Comments

@pdille
Copy link
Contributor

pdille commented Oct 28, 2021

e.g.
https://earthtime.org/explore#v=23.621,-26.21434,0.717,latLng&t=0&ps=50&l=bdrk,berkeley-earth-temperature-anomaly,country_and_city_labels,land_borders_raster&bt=18500101&et=20170331
(Pause and turn on fps meter to see it still redrawing. And if you turn on verbose draw logging, you'll see requests for "Layer bdrk requests redraw")

Here, bdrk is lower draw order and its draw state never gets set, since code (line 300 of layerDB.ts) assumes to ignore drawing of lower layers in this situation. The situation in question has become apparent due to the optimizations around when to redraw.

To rectify this, if a layer with 'isFullExtent' is present, I think any layers with lower draw order should be ignored earlier on and removed from the visible layers array before it even gets to line 300 of layerDB.ts

@pdille pdille changed the title Layers with 'isFullExtent' constraint causes layers with lower draw order to endlessly request redraws Layers with 'isFullExtent' constraint cause layers with lower draw order to endlessly request redraws Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants