[Level3] 김은비 학습 PR제출합니다 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoSeonJe
approved these changes
Feb 16, 2025
There was a problem hiding this comment.
main 메소드가 포함된 클래스가 패키지 내부에 포함되도 괜찮은지 생각해보면 좋을 것 같아요
| import camp.nextstep.edu.missionutils.Randoms; | ||
| import java.util.*; | ||
|
|
||
| public class RacingCarGame { |
There was a problem hiding this comment.
도메인 역할과 컨트롤러 역할을 동시에하고 있는 것 같습니다.
컨트롤러는 어떤 역할인지 고민하시고 분리해보면 좋을 것 같아요
| } | ||
|
|
||
| public void startRace(OutputView outputView) { | ||
| outputView.printMessage("실행 결과"); |
There was a problem hiding this comment.
컨트롤러 내 이와 같이 출력 메시지를 직접 작성해주면 어떤점이 좋지 않을지 고민해보면 좋을 것 같아요
| endWinners(outputView); | ||
| } | ||
|
|
||
| public void raceOnce() { |
|
|
||
| public void raceOnce() { | ||
| for (Car car : cars) { | ||
| if (Randoms.pickNumberInRange(0, 9) >= 4) { //0~9사이의 랜덤 숫자를 뽑아 4이상이면 자동차 이동시킨다 |
There was a problem hiding this comment.
0, 9, 4는 어떤 의미를 가지는 지 상수로 선언해도 좋을 것 같아요
| import java.util.*; | ||
|
|
||
| public class InputView { | ||
| private static final int MAX_NAME_LENGTH = 5; |
There was a problem hiding this comment.
이 상수가 비즈니스 로직에 포함되는지?
비즈니스 로직에 포함된다면 view에 있어도 괜찮을지? 고민해보면 좋을 것 같아요
| } catch (NumberFormatException e) { | ||
| throw new IllegalArgumentException("[ERROR] 숫자를 입력해야 합니다."); | ||
| } | ||
| return tries; |
There was a problem hiding this comment.
try{} 내부에서 선언해도 괜찮을 것 같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.