[10주차] API 개발 미션 (Gopistol) #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dojinyou
reviewed
Sep 17, 2023
Comment on lines
+25
to
+30
| implementation 'org.springframework.boot:spring-boot-starter-data-jpa' | ||
| implementation 'org.springframework.boot:spring-boot-starter-web' | ||
| compileOnly 'org.projectlombok:lombok' | ||
| runtimeOnly 'com.mysql:mysql-connector-j' | ||
| annotationProcessor 'org.projectlombok:lombok' | ||
| testImplementation 'org.springframework.boot:spring-boot-starter-test' |
There was a problem hiding this comment.
별건 아니지만 앞으로는 dependencies도 성격에 맞게 관리해주면 좋을듯!
| public void createComment( | ||
| @PathVariable Long memberId, | ||
| @PathVariable Long postId, | ||
| @RequestBody CommentRequestDTO commentRequestDTO) { |
There was a problem hiding this comment.
Suggested change
| @RequestBody CommentRequestDTO commentRequestDTO) { | |
| @RequestBody CommentRequestDTO commentRequestDTO | |
| ) { |
|
|
||
| private final CommentService commentService; | ||
|
|
||
| @PostMapping("/members/{memberId}/posts/{postId}") |
Comment on lines
+6
to
+11
| @Getter | ||
| @NoArgsConstructor | ||
| public class CommentRequestDTO { | ||
|
|
||
| String comment; | ||
| } |
There was a problem hiding this comment.
Suggested change
| @Getter | |
| @NoArgsConstructor | |
| public class CommentRequestDTO { | |
| String comment; | |
| } | |
| public record CommentRequestDTO(String comment) {} |
record로 처리할 수 있으면 record로 하고 일반 클래스라면 final 넣어주기.
jacksonConverter가 문제라면 @JsonCreator 같은 어노테이션 확인해보기
Comment on lines
+35
to
+37
| public static Comment create(Member member, Post post, String comment) { | ||
| return new Comment(null, comment, member, post); | ||
| } |
There was a problem hiding this comment.
Suggested change
| public static Comment create(Member member, Post post, String comment) { | |
| return new Comment(null, comment, member, post); | |
| } | |
| public static Comment of(Member member, Post post, String comment) { | |
| return new Comment(null, comment, member, post); | |
| } |
정적 팩토리 메서드 네이밍 컨벤션 참고하기!
Comment on lines
+51
to
+60
| List<Member> members = findAllMembers(); | ||
| List<MemberResponseDTO> memberResponseDTOList = new ArrayList<>(members.size()); | ||
| for (Member member : members) { | ||
| MemberResponseDTO memberResponseDTO = new MemberResponseDTO(); | ||
| memberResponseDTO.setAuthId(member.getAuthId()); | ||
| memberResponseDTO.setName(member.getName()); | ||
|
|
||
| memberResponseDTOList.add(memberResponseDTO); | ||
| } | ||
| return memberResponseDTOList; |
| package com.example.demo.post.controller; | ||
|
|
||
| import com.example.demo.post.controller.request.CreatePostRequest; | ||
| //import com.example.demo.post.controller.response.AllPostsResponseDTO; |
| return postService.getAllPosts(); | ||
| } | ||
|
|
||
| @PostMapping("/members/{id}") |
There was a problem hiding this comment.
- path 다시 고민해보기
- 이대로 한다면
memberId라고 명확히 표현하기. post 도메인에서 그냥 id라는 표현은 모호할 수 있다.
|
|
||
| private String content; | ||
|
|
||
| private int commentCount; |
Comment on lines
+58
to
+63
| public void addComment(Comment comment) { | ||
| this.getComments().add(comment); | ||
| comment.setPost(this); | ||
| // 댓글 개수 1 증가시킴 | ||
| plusCommentCount(); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERD
Postman API
https://documenter.getpostman.com/view/26102875/2s9YC32a3s