[7주차]COW-Spring-1 학습(fuirian) #3

fuirian · 2023-08-29T14:23:58Z

wonjunYou

모든 로직이 view에서 흘러가고 있다는 생각이 듭니다. controller가 전체적인 흐름을 담당하고, 데이터를 가져오는 로직은 도메인과 퍼시스턴스 레이어를 적절히 활용하여 이루어지도록 분리해주세요. view와 로직의 분리가 없으면, 결코 mvc라고 할 수 없습니다.

wonjunYou · 2023-09-06T01:10:20Z

src/fuirian/ConsoleUI.java

+
+        GameController gameController = new GameController(carNames);
+
+        for (int i = 0; i < tryCount; i++) {


stream을 적용해볼 수 있을 것 같아요!

wonjunYou · 2023-09-06T01:11:01Z

src/fuirian/ConsoleUI.java

+        List<String> carNames = Arrays.asList(carNamesInput.split(","));
+
+        int tryCount;
+        try {


시도 횟수를 입력받는 부분도 좀 더 작게 메서드로 분리할 수 있을 것 같습니다!

wonjunYou · 2023-09-06T01:12:22Z

src/fuirian/ConsoleUI.java

+            return;
+        }
+
+        GameController gameController = new GameController(carNames);


뷰에서 컨트롤러를 생성해주는 방식은 옳지 않은 것 같습니다!

wonjunYou · 2023-09-06T01:12:38Z

src/fuirian/ConsoleUI.java

+        List<String> carNames = gameController.getCarNames();
+        List<Integer> carPositions = gameController.getCarPositions();
+
+        for (int i = 0; i < carNames.size(); i++) {


STREAM 적용!

wonjunYou · 2023-09-06T01:14:27Z

src/fuirian/Randoms.java

+
+public class Randoms {
+
+	public static int pickNumberInRange(int i, int j) {


해당 메서드가 제대로 구현되어있지 않은 것 같습니다!

[7주차]COW-Spring-1 학습(fuirian)

3155183

wonjunYou reviewed Sep 6, 2023

View reviewed changes

dojinyou assigned fuirian Sep 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7주차]COW-Spring-1 학습(fuirian) #3

[7주차]COW-Spring-1 학습(fuirian) #3

fuirian commented Aug 29, 2023 •

edited

Loading

wonjunYou left a comment

wonjunYou Sep 6, 2023

wonjunYou Sep 6, 2023

wonjunYou Sep 6, 2023

wonjunYou Sep 6, 2023

wonjunYou Sep 6, 2023


		GameController gameController = new GameController(carNames);

		for (int i = 0; i < tryCount; i++) {


		public class Randoms {

		public static int pickNumberInRange(int i, int j) {

[7주차]COW-Spring-1 학습(fuirian) #3

Are you sure you want to change the base?

[7주차]COW-Spring-1 학습(fuirian) #3

Conversation

fuirian commented Aug 29, 2023 • edited Loading

wonjunYou left a comment

Choose a reason for hiding this comment

wonjunYou Sep 6, 2023

Choose a reason for hiding this comment

wonjunYou Sep 6, 2023

Choose a reason for hiding this comment

wonjunYou Sep 6, 2023

Choose a reason for hiding this comment

wonjunYou Sep 6, 2023

Choose a reason for hiding this comment

wonjunYou Sep 6, 2023

Choose a reason for hiding this comment

fuirian commented Aug 29, 2023 •

edited

Loading