Skip to content

Typings incorrectly suggest that Rule.conditions is a setter #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emilefokkemanavara opened this issue May 29, 2025 · 0 comments · May be fixed by #420
Open

Typings incorrectly suggest that Rule.conditions is a setter #419

emilefokkemanavara opened this issue May 29, 2025 · 0 comments · May be fixed by #420

Comments

@emilefokkemanavara
Copy link
Contributor

Rule.conditions is described as being a setter, and is also used as such in one of the tests. But doing this and then running the engine leads to a RuleResult that, when JSON-stringified, will throw an error. (This is because a Rule expects its conditions to be an instance of Condition.)
emilefokkemanavara added a commit to emilefokkemanavara/json-rules-engine that referenced this issue May 29, 2025
@emilefokkemanavara
CacheControl#419 change test to use setter method
8a01446
emilefokkemanavara added a commit to emilefokkemanavara/json-rules-engine that referenced this issue May 29, 2025
@emilefokkemanavara
CacheControl#419 add test for 'wrong' way to set conditions
86f046e
emilefokkemanavara added a commit to emilefokkemanavara/json-rules-engine that referenced this issue May 29, 2025
@emilefokkemanavara
CacheControl#419 update types to mark Rule.conditions as readonly
100a0fd
@emilefokkemanavara emilefokkemanavara linked a pull request May 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Rule.conditions readonly (fixes #419) emilefokkemanavara/json-rules-engine
1 participant
@emilefokkemanavara