Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Various issues with dolphin #1207

Open
10 of 13 tasks
RuiNtD opened this issue Aug 19, 2024 · 2 comments
Open
10 of 13 tasks

[Bug]: Various issues with dolphin #1207

RuiNtD opened this issue Aug 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@RuiNtD
Copy link
Contributor

RuiNtD commented Aug 19, 2024

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

dolphin

Expected/Current Behaviour

I noticed there are a few issues with the dolphin packages, such as:

  • Missing extract_dir (only in dolphin)
    • User directory in persist is in the wrong directory because of this
  • The download link should be in architecture.64bit, since there's no 32-bit version
  • Missing ARM download
    • ARM URL for dolphin-dev is complicated, since the "rand1" and "rand2" matches aren't the same as X64, probably requiring a custom script, which is beyond my knowledge
  • The pre_install script only migrates from the old user directory in Documents and not the new user directory in AppData.
    • Probably don't mess with user space. (Don't delete the old folder...)
    • It also doesn't account for if the scoop package is installed globally, like prismlauncher does. Not sure if this is necessary?
  • add DolphinTool.exe to dolphin stable now that it uses a not comically out of date version #1182
  • dolphin-beta is no longer updated and should probably be removed
  • Should the updater be removed? It doesn't look like Dolphin correctly detects it being missing...

Steps to Reproduce

N/a

Possible Solution

I'm working on the PR to fix most of these issues, but I would like feedback if I should modify the pre_install script to more closely resemble prismlauncher's.

Scoop and Buckets Version

Current Scoop version:
859d1db5 (HEAD -> master, tag: v0.5.2, origin/master, origin/HEAD) chore(release): Bump to version 0.5.2 (#6080)

'main' bucket:
1e2f1397b (HEAD -> master, origin/master, origin/HEAD) radius: Update to version 0.37.0

'extras' bucket:
91a8e2a44 (HEAD -> master, origin/master, origin/HEAD) telegram: Update to version 5.4.1

'versions' bucket:
62beda86f (HEAD -> master, origin/master, origin/HEAD) prismlauncher-git: Update to version 7.0-1b756b9

'nirsoft' bucket:
c22d12d (HEAD -> master, origin/master, origin/HEAD) Update url list [ci skip]

'nerd-fonts' bucket:
b17bbac0 (HEAD -> master, origin/master, origin/HEAD) SarasaGothic: Update to version 1.0.19

'nonportable' bucket:
f73469fd (HEAD -> master, origin/master, origin/HEAD) 10x-np: Update to version 1.0.203

'java' bucket:
84b7bb31 (HEAD -> master, origin/master, origin/HEAD) temurin11-nightly-jre: Update to version 11.0.25-3.0.ea

'games' bucket:
4481f5091 (HEAD -> master, origin/master, origin/HEAD) stonecutter: Update to version 1.2.0

'charm' bucket:
84437d8 (HEAD -> main, origin/main, origin/HEAD) Scoop update for markscribe version v0.8.1

Scoop Config

last_update          scoop_repo                              scoop_branch shim
-----------          ----------                              ------------ ----
8/19/2024 4:43:58 PM https://github.com/ScoopInstaller/Scoop master       kiennq

PowerShell Version

Name                           Value
----                           -----
PSVersion                      7.4.4
PSEdition                      Core
GitCommitId                    7.4.4
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional Softwares

No response

@RuiNtD RuiNtD added the bug Something isn't working label Aug 19, 2024
@RuiNtD
Copy link
Contributor Author

RuiNtD commented Aug 19, 2024

Everything checked in the issue description is finished in the PR. Everything else I either need assistance or feedback on.

@Calinou
Copy link
Owner

Calinou commented Aug 20, 2024

ARM URL for dolphin-dev is complicated, since the "rand1" and "rand2" matches aren't the same as X64, probably requiring a custom script, which is beyond my knowledge

It might be worth bringing this up to Dolphin developers to see if the URL can be made more predictable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants