Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Updated the daily quote section - added padding, colour and right-quote img #386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updated the daily quote section - added padding, colour and right-quote img #386

wants to merge 2 commits into from

Conversation

vismitap
Copy link

Fixed #373

Issue that this pull request solves

Closes: #373

Proposed changes

The proposed changes were:

  • The daily quote should appear on the development server
  • The quote should have a good bottom padding
  • The quote text color should be a bit nicer and attractive

Brief description of what is fixed or changed

Changes made are:

  • Added right quote image to give the quote a better and complete look. Earlier there was just on img <img src="https://img.icons8.com/fluent-systems-filled/24/000000/quote-left.png"/>, so closed it with <img src="https://img.icons8.com/fluent-systems-filled/24/000000/quote-right.png"/>.
  • Changed the opacity and colors of both quoteText and quoteAuthor to make it look more attractive.
  • Added padding at the bottom of quote section.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Final output looks like this:
image

@welcome
Copy link

welcome bot commented Feb 24, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ Canvasboard is an interactive board with plugins focusing on replacing the need of multiple platforms for teaching, presenting or explaining your ideas. The interactive plugins are built using web technologies to ease your work right within a single platform. Please adhere to our Code of Conduct.🙌 We will get back to you as soon as we can 😄.
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@vismitap vismitap changed the title Updated the daily quote section - added padding, colour and right-quote img added Updated the daily quote section - added padding, colour and right-quote img Feb 24, 2021
@goliakshay357
Copy link
Member

Hey @vismitap,
Thanks for your interest for solving this issue but I don't see the quotes when workspace are filled.
Screenshot
image

Couple of suggestions:

  1. Following the color format would be great. (Same patterns of black is preferred)
  2. Quote shall always be in the bottom of the page, even if the workspace is empty.

Please feel free to message us on slack channel in case if you need any help or guidance.
Thanks

@vismitap
Copy link
Author

vismitap commented Feb 25, 2021 •
edited
Loading

Hey @vismitap,
Thanks for your interest for solving this issue but I don't see the quotes when workspace are filled.
Screenshot
image

Couple of suggestions:

  1. Following the color format would be great. (Same patterns of black is preferred)
  2. Quote shall always be in the bottom of the page, even if the workspace is empty.

Please feel free to message us on slack channel in case if you need any help or guidance.
Thanks

  • I changed the colour because that was mentioned in the deliverable in [Bug] Daily Quote not appearing in development server #373, I can change that to black again if you want.
  • I can see the quote even after adding the workspace in the local host.
    image
  • The quote is always in the bottom as you can see in the screenshot.
    I don't know what the issue is in the deployment. 🤔

Hey btw, how are you checking in deployment server even before the code is merged? Is there any tool for that? 🤔🤩

@goliakshay357
Copy link
Member

Hey @vismitap,
Netlify provides us the flexibility of auto deployment preview of each PR. Can you message me on slack?
Would love to debug together.

Thanks

@vismitap
Copy link
Author

Hey @vismitap,
Netlify provides us the flexibility of auto deployment preview of each PR. Can you message me on slack?
Would love to debug together.

Thanks

Yes sure!

@vismitap
Copy link
Author

What's your username on slack? Could not find you on canvas board channel.

@goliakshay357
Copy link
Member

What's your username on slack? Could not find you on canvas board channel.

Display name: Goli Akshay Sujith
Slack Invite
Thanks

@vismitap
Copy link
Author

vismitap commented Feb 27, 2021 •
edited
Loading

Hey @goliakshay357 ! Added json file having a list of quotes in the src/interfaces folder and changed the color of quotes back to black. Added some padding to the container as well. I hope it works now! Here is the screenshot:
image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goliakshay357 goliakshay357 Awaiting requested review from goliakshay357

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Daily Quote not appearing in development server
2 participants
@vismitap @goliakshay357