Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Removed the navigate to top button #464

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed the navigate to top button #464

wants to merge 1 commit into from

Conversation

sakkshm26
Copy link

@sakkshm26 sakkshm26 commented Oct 23, 2021 •
edited
Loading

Issue that this pull request solves

Closes: #455

Proposed changes

Brief description of what is fixed or changed

Removed the navigate to top button

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Screenshot (400)

Other information

Any other information that is important to this pull request

@welcome
Copy link

welcome bot commented Oct 23, 2021

Hello there!👋 Welcome to the project!💖

Thank you and congrats🎉 for opening your first pull request.✨ Canvasboard is an interactive board with plugins focusing on replacing the need of multiple platforms for teaching, presenting or explaining your ideas. The interactive plugins are built using web technologies to ease your work right within a single platform. Please adhere to our Code of Conduct.🙌 We will get back to you as soon as we can 😄.
Feel free to join our Slack Community.💖 We have different channels for active discussions.✨ Hope you have a great time there!😄

@sakkshm26
Copy link
Author

@goliakshay357 can you please review this PR?

@goliakshay357
Copy link
Member

Hello @sakkshm26,
Please check the review comment. As mentioned, You cannot delete the global component.

One way to solve this problem is by manually injecting the component in the required templates instead of just adding it in the app-component [which is the main component].

Let me know if you need any help.
Thanks :)

@sakkshm26
Copy link
Author

@goliakshay357 Is scroll-to-top the required template?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove navigate to top in the home component
2 participants
@sakkshm26 @goliakshay357