Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick and then fix/change what happens to user's name on the Recent Listings pane #163

Open
JSlote opened this issue Aug 30, 2016 · 4 comments
Labels
Milestone

Comments

@JSlote
Copy link
Member

JSlote commented Aug 30, 2016

Login, logout doesn't reset their names

@JSlote JSlote added the bug label Aug 30, 2016
@dpikt dpikt added this to the v3 milestone Aug 30, 2016
@taoduo
Copy link

taoduo commented Sep 6, 2016

Do you mean the names of the sellers? What do you want to reset the names to? Maybe the names can not be seen after log out?

@JSlote
Copy link
Member Author

JSlote commented Sep 6, 2016

Right now I'm using the fullname attribute on the recent listings view. When a user isn't logged in, the server only outputs the user's given name as fullName to preserve privacy, but when a user is logged in fullName is givenName + ' ' + familyName. Right now if you log in, the names stay as just first names until you refresh the page. So that's a bug (it should resend the request to get everything directly on login).

On the other hand, David thought we should just use first names always.

@taoduo
Copy link

taoduo commented Sep 6, 2016

I see. I think either way is fine. After all, users are more interested in the books than who is selling it.

@JSlote
Copy link
Member Author

JSlote commented Sep 6, 2016

I agree. However, I think because the transactions occur face-to-face, it's really important to communicate specificity and authenticity the users, especially if they're new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants