Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with core/tabs/utils/ssh.sh #996

Open
adamperkowski opened this issue Jan 11, 2025 · 0 comments
Open

Issues with core/tabs/utils/ssh.sh #996

adamperkowski opened this issue Jan 11, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@adamperkowski
Copy link
Collaborator

First of all, shellcheck.
Second of all, those quotes actually unquote the variable:

linutil/core/tabs/utils/ssh.sh

Lines 65 to 69 in d91a44e

"$ESCALATION_TOOL" -S sed -i 's/^#PasswordAuthentication yes/PasswordAuthentication no/' /etc/ssh/sshd_config &&
"$ESCALATION_TOOL" -S sed -i 's/^PasswordAuthentication yes/PasswordAuthentication no/' /etc/ssh/sshd_config &&
"$ESCALATION_TOOL" -S sed -i 's/^#PubkeyAuthentication no/PubkeyAuthentication yes/' /etc/ssh/sshd_config &&
"$ESCALATION_TOOL" -S sed -i 's/^PubkeyAuthentication no/PubkeyAuthentication yes/' /etc/ssh/sshd_config &&
"$ESCALATION_TOOL" -S systemctl restart sshd

Third of all, $ESCALATION_TOOL in this case is being expanded on the client side...
The list goes on. We need someone to refactor that whole script.
@adamperkowski adamperkowski added the bug Something isn't working label Jan 11, 2025
adamperkowski added a commit to adamperkowski/linutil-dev that referenced this issue Jan 11, 2025
@adamperkowski
refact: fix (almost) all shellcheck errors
1fe60f5 
the only files i didn't fix:
- core/tabs/utils/ssh.sh (ref ChrisTitusTech#996)
- core/tabs/system-setup/arch/server-setup.sh
@adamperkowski adamperkowski mentioned this issue Jan 11, 2025
Merged
adamperkowski added a commit to adamperkowski/linutil-dev that referenced this issue Jan 11, 2025
@adamperkowski
refact: fix (almost) all shellcheck errors
414c757 
the only files i didn't fix:
- core/tabs/utils/ssh.sh (ref ChrisTitusTech#996)
- core/tabs/system-setup/arch/server-setup.sh
adamperkowski added a commit to adamperkowski/linutil-dev that referenced this issue Jan 11, 2025
@adamperkowski
refact: fix (almost) all shellcheck and shfmt errors
d93d81a 
the only files i didn't fix:
- core/tabs/utils/ssh.sh (ref ChrisTitusTech#996)
- core/tabs/system-setup/arch/server-setup.sh
ChrisTitusTech pushed a commit that referenced this issue Feb 2, 2025
@adamperkowski
refact: fix (almost) all shellcheck errors (#997)
5f7de33 
the only files i didn't fix:
- core/tabs/utils/ssh.sh (ref #996)
- core/tabs/system-setup/arch/server-setup.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adamperkowski