Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composition Keys are not properly formatted #103

Closed
ghzdude opened this issue Jan 8, 2025 · 1 comment
Closed

Composition Keys are not properly formatted #103

ghzdude opened this issue Jan 8, 2025 · 1 comment

Comments

@ghzdude
Copy link
Contributor

ghzdude commented Jan 8, 2025

Compositions keys do not have/use a getFormatted() method, so keys lose formatting when turned into a string
@ghzdude
Copy link
Contributor Author

ghzdude commented Jan 8, 2025

okay, specifically i think comp keys don't call getFormatted() in their get()

also, formatting doesn't work correctly with nested keys (RESET is used instead of parent's formatting)

YannickMG pushed a commit to GTNewHorizons/ModularUI2 that referenced this issue Jan 26, 2025
@brachy84 @YannickMG
fix CleanroomMC#103
eb14191 
(cherry picked from commit 606032d)
YannickMG pushed a commit to GTNewHorizons/ModularUI2 that referenced this issue Jan 26, 2025
@brachy84 @YannickMG
fix CleanroomMC#103
1add965 
(cherry picked from commit 606032d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ghzdude