Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include left and right border radius classes #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

include left and right border radius classes #263

wants to merge 1 commit into from

Conversation

prime-time
Copy link
Contributor

@prime-time prime-time commented Feb 2, 2018 •
edited
Loading

Overview:
We want to have a small border radius on just one side of a component, so I thought we may want to include new classes for this.

Screenshots/GIFs:
screen shot 2018-02-02 at 3 31 12 pm
We want a border radius on just the left of "This District" and on the right of the search bar.
screen shot 2018-02-02 at 3 34 36 pm

Testing:

  • Unit tests
  • Manual tests:
    • Chrome
    • Safari
    • IE10

Roll Out:

  • Before merging:
    • Updated docs
    • Bumped version in package.json
      • Breaking change? Run npm version minor
      • Backward compatible change? Run npm version patch
      • Only changing documentation? All good. Skip this step.
  • After merging:
    • Deployed updated docs (make deploy-docs)

@prime-time prime-time requested a review from potluck February 2, 2018 23:36
@cozmo
Copy link
Contributor

cozmo commented Feb 2, 2018 •
edited
Loading

components/src/less/border_radius.less

Lines 3 to 8 in b31c957

/**
* Common border-radius definitions.
*
* Auto-generated file.
* To re-generate, run `make border-radius-styles`
*/

Seems like this file is auto generated, can you make changes to the script that generated it vs to the file directly?

@prime-time
Copy link
Contributor Author

lol wops

@prime-time prime-time force-pushed the left-and-right-border-radius branch from b31c957 to 9502ae7 Compare February 2, 2018 23:48
@prime-time prime-time force-pushed the left-and-right-border-radius branch from 9502ae7 to aa69000 Compare February 2, 2018 23:51
@prime-time
Copy link
Contributor Author

Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potluck potluck Awaiting requested review from potluck

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prime-time @cozmo @renatoprime