Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
:convert-timezone
feature is disabled for now.max-open-connections
configuration option; default is 100.The CI uses a fork again (see metabase/metabase@v1.52.2.5...slvrtrn:metabase:0.52.x-ch); we've come a full circle. A few tests fail:
better-error-when-parameter-mismatch
worked before, as was always generating an invalid CH query.iso-8601-text-fields
has a ton of different hardcoded versions of it for different databasesfilter-test
(MBQL datetime literal...
) fails for an unknown reason and it's not clear how we can deduce what we are supposed to do in this case in our QP implementation.Checklist