Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the driver to use JDBC v2 #277

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Update the driver to use JDBC v2 #277

wants to merge 4 commits into from

Conversation

slvrtrn
Copy link
Collaborator

@slvrtrn slvrtrn commented Dec 23, 2024

Summary

The CI uses a fork again (see metabase/metabase@v1.52.2.5...slvrtrn:metabase:0.52.x-ch); we've come a full circle. A few tests fail:

  • Unclear how better-error-when-parameter-mismatch worked before, as was always generating an invalid CH query.
  • iso-8601-text-fields has a ton of different hardcoded versions of it for different databases
  • One branch of filter-test (MBQL datetime literal...) fails for an unknown reason and it's not clear how we can deduce what we are supposed to do in this case in our QP implementation.

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run tests against Java 21
1 participant