WIP: Towards abstract MARGO data structures #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2020
|
I've started addressing #29 here. |
|
Should see if the issue of JuMPification of the MARGO diagnostics (#18) can be addressed in this PR. It really would be a pain if every diagnostic would have to be re-written within JuMP every time an existing one is changed or a new one is implemented. |
The primary remaining task is to re-implement the optimization algorithm around the new data structures. The most challenging part will be re-implementing the objective functions and constraints for the JuMP optimization, but the new multiply-dispatched diagnostic functions should help since they can in principle be registered to JuMP.
The two-layer model breaks with kappa = 0 because parameters all ill-defined. Instead we can just set kappa = 1e.-8 to recover the behavior of the upper-layer (one-box) model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.