Support for building latest quicly version #340
Conversation
|
One of the actions failed for clang-format please click the details link and correct the problem before you convert the PR to a non-draft status. Thanks. |
Signed-off-by: Pavo Banicevic <[email protected]>
|
Looks good, did you want to convert this to non-draft version and I can approve and merge. Thanks |
| @@ -56,7 +57,7 @@ if quicly_dep.found() | |||
| quic_cflags += arg | |||
| endif | |||
| endforeach | |||
| quic_cflags += ['-I'+quicly_path+'/include', '-I'+picotls_path+'/include'] | |||
| quic_cflags += ['-I'+quicly_path+'/../include', '-I'+picotls_path+'/../include'] | |||
There was a problem hiding this comment.
This change doesn't work if you follow the readme to build the quicly and picotls dirs
There was a problem hiding this comment.
Needed this to get it build locally, but can remove if it breaks compilation in your case.
|
Is this one ready to merge and move out of draft status? |
|
I think another pull request toke changes from here with additional commits/fixes on top. so one can close this draft PR once that PR is merged. |
|
Yeah sorry - I pulled this into #343. We should be good to close this one. |
|
Integrated into #343. |
This fixes building issues with latest quicly version.
Need to be run tested with some typical setup, see #334