Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look up / Search component #12

Open
4 tasks
LucyMac opened this issue Feb 4, 2023 · 1 comment
Open
4 tasks

Look up / Search component #12

LucyMac opened this issue Feb 4, 2023 · 1 comment
Assignees
@zkhing

Comments

@LucyMac
Copy link

LucyMac commented Feb 4, 2023

UI STAGE

  • Input element html and css
  • button element html and css

FUNCTIONALITY STAGE

  • take city
  • return weather
@LucyMac LucyMac converted this from a draft issue Feb 4, 2023
@LucyMac LucyMac changed the title Look up Look up / Search component Feb 4, 2023
@LucyMac LucyMac moved this from 📋 Backlog to 🏗 In progress in Rainy Playtime Hackathon Kanban Feb 25, 2023
@LucyMac LucyMac moved this from 🏗 In progress to 👀 In review in Rainy Playtime Hackathon Kanban Feb 25, 2023
@LucyMac
Copy link
Author

LucyMac commented Feb 25, 2023

@zkhing you have already done the Functionality stage of this ticket 🌟 however as mentioned in your PR #28 the logic lives in the wrong component. You also still need to style it appropriately to tick the UI tasks above.

IN order for this project to advance as a team though, let's get what you've already done merged in first, and then start a new branch to improve the UI and move the logic to the right place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zkhing zkhing

Labels
None yet
Projects
Rainy Playtime Hackathon Kanban
Status: 👀 In review
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucyMac @zkhing