Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Trigger locale update from ComfyUI main repo #2132

Closed
huchenlei opened this issue Jan 3, 2025 · 0 comments · Fixed by #2170
Closed

[DevTask] Trigger locale update from ComfyUI main repo #2132

huchenlei opened this issue Jan 3, 2025 · 0 comments · Fixed by #2170
Assignees
Labels
enhancement New feature or request

Comments

@huchenlei
Copy link
Member

huchenlei commented Jan 3, 2025

Currently when the node definition changes, the local update is picked up in the first frontend repo PR that ran CI against the change in the ComfyUI main repo, which creates a messy commit history.

I would propose we add a new github action in the ComfyUI core repo to notify frontend repo of node definition change, and run locale update of node definitions in the frontend repo.

┆Issue is synchronized with this Notion page by Unito

@huchenlei huchenlei self-assigned this Jan 3, 2025
@huchenlei huchenlei added the enhancement New feature or request label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant