Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTask] Move base path to desktop app config #618

Open
webfiltered opened this issue Jan 14, 2025 · 0 comments
Open

[DevTask] Move base path to desktop app config #618

webfiltered opened this issue Jan 14, 2025 · 0 comments
Assignees

Comments

@webfiltered
Copy link
Contributor

webfiltered commented Jan 14, 2025

Current

base_path in extra_models_config.yaml is used as both the desktop install location, and for its original intent - absolute base path of relative model / custom node paths defined in the yaml file.

  • Desktop app uses another config file for the rest of its config
  • Code is unnecessarily complex
  • Users edit the yaml file by hand to add/remove model paths, and a single yaml syntax error will result in the app being unable to launch

Solution

  • Rename basePath in desktop config to installPath
  • Use installPath in desktop config as the desktop install location
  • Use base_path in yaml exclusively for its original purpose

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant