From a70edd0ae65c498d255264293ff4373605dbef97 Mon Sep 17 00:00:00 2001 From: filtered <176114999+webfiltered@users.noreply.github.com> Date: Fri, 3 Jan 2025 21:42:02 +1100 Subject: [PATCH 1/2] Update package: systeminformation - PowerShell PATH https://github.com/sebhildebrandt/systeminformation/issues/957 --- package.json | 2 +- yarn.lock | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 33ea6bd4..5e8c43d9 100644 --- a/package.json +++ b/package.json @@ -104,7 +104,7 @@ "electron-log": "^5.2.0", "electron-store": "8.2.0", "node-pty": "^1.0.0", - "systeminformation": "^5.23.5", + "systeminformation": "^5.24.8", "tar": "^7.4.3", "tmp": "^0.2.3", "wait-on": "^8.0.1", diff --git a/yarn.lock b/yarn.lock index 91a6b4b3..8ff4be20 100644 --- a/yarn.lock +++ b/yarn.lock @@ -314,7 +314,7 @@ __metadata: node-pty: "npm:^1.0.0" prettier: "npm:^3.3.3" rimraf: "npm:^6.0.1" - systeminformation: "npm:^5.23.5" + systeminformation: "npm:^5.24.8" tar: "npm:^7.4.3" tmp: "npm:^0.2.3" ts-node: "npm:^10.0.0" @@ -11437,12 +11437,12 @@ __metadata: languageName: node linkType: hard -"systeminformation@npm:^5.23.5": - version: 5.23.5 - resolution: "systeminformation@npm:5.23.5" +"systeminformation@npm:^5.24.8": + version: 5.24.8 + resolution: "systeminformation@npm:5.24.8" bin: systeminformation: lib/cli.js - checksum: 10c0/849283b2886c46ff5e79594e939c87202b5283b8aa16cd0d665c595781dba51913060728bae95b94837b78c3a515a0f00ab0a0471604990c5c778f555bd075ea + checksum: 10c0/d23b41a4deb23d368b0b8e7991598e0534a818a76aa79f528fd2b724b575c41bc5faf9264f9adffac8ea34768371fc619384207d081d7f7e2542c330499ceddc conditions: (os=darwin | os=linux | os=win32 | os=freebsd | os=openbsd | os=netbsd | os=sunos | os=android) languageName: node linkType: hard From a445b3447741e70cde15f3f37bfcd2524092884d Mon Sep 17 00:00:00 2001 From: filtered <176114999+webfiltered@users.noreply.github.com> Date: Fri, 3 Jan 2025 21:40:29 +1100 Subject: [PATCH 2/2] Fix cannot start ComfyUI: File not found - Resolves various issues caused at different installation states, when PowerShell is not in PATH - Forces standard env for all users - uses Windows PowerShell even if PS core is default --- src/shell/util.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/shell/util.ts b/src/shell/util.ts index ed638d57..bb7ce2d3 100644 --- a/src/shell/util.ts +++ b/src/shell/util.ts @@ -3,7 +3,8 @@ import os from 'node:os'; export function getDefaultShell(): string { switch (os.platform()) { case 'win32': - return 'powershell.exe'; + // Use full path to avoid e.g. https://github.com/Comfy-Org/desktop/issues/584 + return `${process.env.SYSTEMROOT}\\System32\\WindowsPowerShell\\v1.0\\powershell.exe`; case 'darwin': return 'zsh'; default: // Linux and others