diff --git a/src/validate_nodes.py b/src/validate_nodes.py index 248d029..7fef838 100644 --- a/src/validate_nodes.py +++ b/src/validate_nodes.py @@ -8,10 +8,7 @@ class BreakingChangeType(Enum): RETURN_TYPES_CHANGED = "Return types changed" - INPUT_REMOVED = "Required input removed" - INPUT_TYPE_CHANGED = "Input type changed" NODE_REMOVED = "Node removed" - FUNCTION_CHANGED = "Entry point function changed" @dataclass class BreakingChange: @@ -104,24 +101,6 @@ def compare_return_types(node_name: str, base_class: Type, pr_class: Type) -> li return changes -def compare_function(node_name: str, base_class: Type, pr_class: Type) -> list[BreakingChange]: - """Compare FUNCTION attribute between base and PR versions of a node.""" - changes = [] - - base_function = getattr(base_class, "FUNCTION", None) - pr_function = getattr(pr_class, "FUNCTION", None) - - if base_function != pr_function: - changes.append(BreakingChange( - node_name=node_name, - change_type=BreakingChangeType.FUNCTION_CHANGED, - details="Entry point function changed", - base_value=base_function, - pr_value=pr_function - )) - - return changes - def compare_nodes(base_nodes: Dict[str, Type], pr_nodes: Dict[str, Type]) -> list[BreakingChange]: """Compare two versions of nodes for breaking changes.""" changes = [] @@ -140,7 +119,6 @@ def compare_nodes(base_nodes: Dict[str, Type], pr_nodes: Dict[str, Type]) -> lis pr_class = pr_nodes[node_name] changes.extend(compare_return_types(node_name, base_class, pr_class)) - changes.extend(compare_function(node_name, base_class, pr_class)) return changes diff --git a/tests/test_validate_nodes.py b/tests/test_validate_nodes.py index e3fccfd..4bf3716 100644 --- a/tests/test_validate_nodes.py +++ b/tests/test_validate_nodes.py @@ -59,43 +59,3 @@ def test_compare_return_types_missing(): assert changes[0].base_value == ("STRING", "INT", "FLOAT") assert changes[0].pr_value == tuple() - -def test_compare_function(): - from src.validate_nodes import compare_function, BreakingChangeType - - class BaseNode: - FUNCTION = "process" - - class PRNode: - FUNCTION = "process" - - class ChangedNode: - FUNCTION = "different_process" - - class NoFunctionNode: - pass - - # Test 1: No changes - changes = compare_function("TestNode", BaseNode, PRNode) - assert len(changes) == 0 - - # Test 2: Function changed - changes = compare_function("TestNode", BaseNode, ChangedNode) - assert len(changes) == 1 - assert changes[0].change_type == BreakingChangeType.FUNCTION_CHANGED - assert changes[0].base_value == "process" - assert changes[0].pr_value == "different_process" - - # Test 3: Function removed - changes = compare_function("TestNode", BaseNode, NoFunctionNode) - assert len(changes) == 1 - assert changes[0].change_type == BreakingChangeType.FUNCTION_CHANGED - assert changes[0].base_value == "process" - assert changes[0].pr_value is None - - # Test 4: Function added (not a breaking change if base had none) - changes = compare_function("TestNode", NoFunctionNode, BaseNode) - assert len(changes) == 1 - assert changes[0].change_type == BreakingChangeType.FUNCTION_CHANGED - assert changes[0].base_value is None - assert changes[0].pr_value == "process"