Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename balanceOf to balanceOfInContributionToken #13

Open
sembrestels opened this issue Oct 26, 2021 · 0 comments
Open

Rename balanceOf to balanceOfInContributionToken #13

sembrestels opened this issue Oct 26, 2021 · 0 comments
Labels
Sohkai's review
Milestone
v2

Comments

@sembrestels
Copy link
Contributor

From sohkai's review: balanceOf() function is confusing, may be better with a more explicit name like balanceOfInContributionToken().

We leave this change for v2 because it changes the public API used by the frontend.
@sembrestels sembrestels added this to the v2 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sohkai's review
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@sembrestels