Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check timeSinceOpen() properly #6

Open
sembrestels opened this issue Oct 26, 2021 · 1 comment
Open

Check timeSinceOpen() properly #6

sembrestels opened this issue Oct 26, 2021 · 1 comment
Labels
Sohkai's review

Comments

@sembrestels
Copy link
Contributor

sembrestels commented Oct 26, 2021 •
edited
Loading

From Sohkai's review: State.Funding state should still be present when _timeSinceOpen() == period (i.e. more correct as _timeSinceOpen() <= period).
@sembrestels
Copy link
Contributor Author

If we change this check, many tests will fail, as at the end of the hatch period the state should be or Goal Reached or Refunding. I think changing this check changes the specification, and this could have unintended consequences.

Was changing this check a strong advice? Is it affecting something else than just the deadline in which somebody can contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sohkai's review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sembrestels