Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make close() permissionless #7

Open
sembrestels opened this issue Oct 26, 2021 · 1 comment
Open

Make close() permissionless #7

sembrestels opened this issue Oct 26, 2021 · 1 comment
Labels
Sohkai's review
Milestone
v2

Comments

@sembrestels
Copy link
Contributor

From Sohkai's review: Does close() need to be guarded by a role? Wouldn't it be better if anyone could call it? Worried that the account who needs to call close() never does.

Note: close() is being used by a separate app, to finalize the initial fundraise. Consider changing the functionality in the separate app to read from a closed Hatch than requiring only that app to call close().
@sembrestels
Copy link
Contributor Author

Changing this implies changes in the Impact Hours, Hatch Template, and many documentation. We leave it for the future.

@sembrestels sembrestels added this to the v2 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sohkai's review
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@sembrestels