Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What on earth are we doing with Mobx stores? #14

Open
mmmoli opened this issue Mar 25, 2020 · 1 comment
Open

What on earth are we doing with Mobx stores? #14

mmmoli opened this issue Mar 25, 2020 · 1 comment
Labels
question Further information is requested

Comments

@mmmoli
Copy link
Member

mmmoli commented Mar 25, 2020 •
edited
Loading

Built really quickly, but should we keep them? Apollo has a bunch of internal statement management.

The only real use of importance is the PersonStore. As the graph API only stores uid we have to look up the public profile corresponding to that uid. It then acts as a session cache so that we don't keep hitting FB (to save costs).

Is this ok? What should we be doing?
@pongponk
Copy link
Member

What on earth are we doing with Mobx stores?

@mmmoli mmmoli added the question Further information is requested label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmmoli @pongponk