Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement direct storage of enums #22

Closed
wants to merge 8 commits into from

Conversation

petero-dk
Copy link
Contributor

Convert enum to string, and allow for ints to be converted to enums if they match an enum value.

Replaces #11

@DavidVollmers
Copy link
Collaborator

This looks good to me. We should merge it.

@petero-dk
Copy link
Contributor Author

What do you need from me?

@dei79
Copy link
Member

dei79 commented Mar 31, 2023

Looks good but the checks are failed, can you check what is missing?

@petero-dk
Copy link
Contributor Author

The build failed because it could not run the build because of a key restriction. I will force a new build so I can see the logs

@petero-dk
Copy link
Contributor Author

"Could not find file '/home/runner/.corehelpers.credentials.txt'."

@petero-dk
Copy link
Contributor Author

@dei79 same problem as #24 it cannot get the credentials for testing from your CI system. Also as the other PR I am using this a lot and would really like to move to the official version again.

@petero-dk
Copy link
Contributor Author

Replaced by #22

@petero-dk petero-dk closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants