Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log non-fatal issues as errors #531

Closed
Shnatsel opened this issue Nov 1, 2023 · 0 comments · Fixed by #542
Closed

Don't log non-fatal issues as errors #531

Shnatsel opened this issue Nov 1, 2023 · 0 comments · Fixed by #542

Comments

@Shnatsel
Copy link
Contributor

Shnatsel commented Nov 1, 2023

In generator.rs there are numerous places where log::error! is used for non-fatal issues - that is, those that do not cause SBOM generation to be aborted.

image

These issues should be presented as warnings instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report non-fatal issues as warnings, not errors Shnatsel/cyclonedx-rust-cargo
1 participant
@Shnatsel