Translation of strings.xml in English #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N.B. Punctuation is different in French ( !) There are many apostrophes in the French and I didn't add a / in front of them as was done in English. I'm not certain of what was meant in line 84, so I translated it literally.
|
Thank you for this. We will review this on Monday. |
MatthewTighe
requested changes
Dec 4, 2018
There was a problem hiding this comment.
To add localization on Android, strings.xml must be placed in an appropriate directory. The system will then manage the translation automatically.
To be specific, the translations you have added should go in
app/src/main/res/values-fr/strings.xml.
The file you have changed needs to be reverted to its original form, or the app will be presented in French by default.
I.e. app/src/main/res/values/strings.xml should be reverted to its original, English form and app/src/main/res/values-fr/strings.xml should contain the French translated version of the file.
Thanks for your contribution!
|
Can you do this, please ? I thought I was creating a fork… and was proceeding by trial and error. I’m sorry If I goofed.
Provenance : Courrier<https://go.microsoft.com/fwlink/?LinkId=550986> pour Windows 10
…________________________________
De : Matthew Tighe <[email protected]>
Envoyé : Tuesday, December 4, 2018 1:03:32 AM
À : CypherpunkArmory/UserLAnd
Cc : AuntieE; Author
Objet : Re: [CypherpunkArmory/UserLAnd] Translation of strings.xml in English (#439)
@MatthewTighe requested changes on this pull request.
To add localization on Android, strings.xml must be placed in an appropriate directory. The system will then manage the translation automatically.
To be specific, the translations you have added should go in
app/src/main/res/values-fr/strings.xml.
The file you have changed needs to be reverted to its original form, or the app will be presented in French by default.
I.e. app/src/main/res/values/strings.xml should be reverted to its original, English form and app/src/main/res/values-fr/strings.xml should contain the French translated version of the file.
Thanks for your contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#439 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ArNg8p37tMHathMkEqqBQ8YeUxZSn1luks5u1bvUgaJpZM4Y8_Qj>.
|
|
No worries, I can take care of it for you. |
|
Okay, your translations have been merged in. You will be able to view UserLAnd in French after our next release. Thanks for your hard work! |
|
Many thanks to you !
Provenance : Courrier<https://go.microsoft.com/fwlink/?LinkId=550986> pour Windows 10
…________________________________
De : Matthew Tighe <[email protected]>
Envoyé : Tuesday, December 4, 2018 6:15:30 PM
À : CypherpunkArmory/UserLAnd
Cc : AuntieE; Author
Objet : Re: [CypherpunkArmory/UserLAnd] Translation of strings.xml in English (#439)
No worries, I can take care of it for you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#439 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ArNg8p10g7xWhSBifMAws_EUe-scusvVks5u1q2ygaJpZM4Y8_Qj>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N.B. Punctuation is different in French ( !) There are many apostrophes in the French and I didn't add a / in front of them as was done in English.
I'm not certain of what was meant in line 84, so I translated it literally.
Describe the pull request
English translation of strings.
Link to relevant issues
Issue #430 Translations needed