From 20a9b0435de5f0ac8aa096cf177c150b09b6882c Mon Sep 17 00:00:00 2001
From: Yaacov <yaacov@goodimpact.studio>
Date: Fri, 15 Nov 2024 17:24:48 +0100
Subject: [PATCH] Fix duplicate ids in errors and improvements tabs

---
 .../src/components/report/ReportCriteria.vue  | 19 ++++++++++++-------
 .../src/components/report/ReportErrors.vue    |  5 +++--
 .../components/report/ReportImprovements.vue  |  8 ++++++--
 3 files changed, 21 insertions(+), 11 deletions(-)

diff --git a/confiture-web-app/src/components/report/ReportCriteria.vue b/confiture-web-app/src/components/report/ReportCriteria.vue
index 74ba0371..e68103af 100644
--- a/confiture-web-app/src/components/report/ReportCriteria.vue
+++ b/confiture-web-app/src/components/report/ReportCriteria.vue
@@ -9,6 +9,7 @@ import { ReportImprovement } from "./getReportImprovements";
 defineProps<{
   count: number;
   pagesData: ReportError[] | ReportImprovement[];
+  tabSlug: string;
   transverseData: ReportError | ReportImprovement;
   showFilters?: boolean;
   topNotice?: string;
@@ -36,12 +37,12 @@ const hasFilters = computed(() => {
           <button
             class="fr-sidemenu__btn"
             hidden
-            aria-controls="fr-sidemenu-wrapper"
+            :aria-controls="`report-${tabSlug}_sidemenu-wrapper`"
             aria-expanded="false"
           >
             Pages
           </button>
-          <div id="fr-sidemenu-wrapper" class="fr-collapse">
+          <div :id="`report-${tabSlug}_sidemenu-wrapper`" class="fr-collapse">
             <div class="fr-sidemenu__title fr-mb-2w">Pages</div>
             <ul class="fr-sidemenu__list">
               <li
@@ -56,10 +57,10 @@ const hasFilters = computed(() => {
               >
                 <a
                   class="fr-sidemenu__link"
-                  href="#elements-transverses"
+                  :href="`#${tabSlug}_elements-transverses`"
                   :aria-current="
                     route.hash
-                      ? isActive('#elements-transverses')
+                      ? isActive(`#${tabSlug}_elements-transverses`)
                         ? 'true'
                         : undefined
                       : 'true'
@@ -72,13 +73,17 @@ const hasFilters = computed(() => {
                 :key="page.name"
                 class="fr-sidemenu__item"
                 :class="{
-                  'fr-sidemenu__item--active': isActive(`#${page.id}`)
+                  'fr-sidemenu__item--active': isActive(
+                    `#${tabSlug}_${page.id}`
+                  )
                 }"
               >
                 <a
                   class="fr-sidemenu__link"
-                  :href="`#${page.id}`"
-                  :aria-current="isActive(`#${page.id}`) ? 'true' : undefined"
+                  :href="`#${tabSlug}_${page.id}`"
+                  :aria-current="
+                    isActive(`#${tabSlug}_${page.id}`) ? 'true' : undefined
+                  "
                 >
                   {{ page.name }}
                 </a>
diff --git a/confiture-web-app/src/components/report/ReportErrors.vue b/confiture-web-app/src/components/report/ReportErrors.vue
index a02a250e..937afbb3 100644
--- a/confiture-web-app/src/components/report/ReportErrors.vue
+++ b/confiture-web-app/src/components/report/ReportErrors.vue
@@ -100,6 +100,7 @@ function resetFilters() {
     :pages-data="pagesErrors"
     :transverse-data="transverseErrors"
     :show-filters="true"
+    tab-slug="errors"
   >
     <template #filter>
       <div class="fr-text--bold fr-text--xl fr-mb-2w filter-title">Filtres</div>
@@ -198,7 +199,7 @@ function resetFilters() {
 
     <template v-if="transverseErrors.topics.length" #transverse-data>
       <section class="fr-mb-8w">
-        <h2 id="elements-transverses" class="fr-h3 fr-mb-2w page-title">
+        <h2 id="errors_elements-transverses" class="fr-h3 fr-mb-2w page-title">
           Éléments transverses
         </h2>
 
@@ -223,7 +224,7 @@ function resetFilters() {
 
     <template #pages-data>
       <section v-for="page in pagesErrors" :key="page.id" class="fr-mb-8w">
-        <h2 :id="`${page.id}`" class="fr-h3 fr-mb-2w page-title">
+        <h2 :id="`errors_${page.id}`" class="fr-h3 fr-mb-2w page-title">
           {{ page.name }}
         </h2>
         <a
diff --git a/confiture-web-app/src/components/report/ReportImprovements.vue b/confiture-web-app/src/components/report/ReportImprovements.vue
index 59265a1d..31b92c30 100644
--- a/confiture-web-app/src/components/report/ReportImprovements.vue
+++ b/confiture-web-app/src/components/report/ReportImprovements.vue
@@ -29,11 +29,15 @@ const improvementsCount = computed(() => {
     top-notice="Ci-dessous les commentaires de l’auditeur ou de l’auditrice concernant des critères conformes ou non applicables."
     :count="improvementsCount"
     :pages-data="pagesImprovements"
+    tab-slug="improvements"
     :transverse-data="transverseImprovements"
   >
     <template #transverse-data>
       <section class="fr-mb-8w">
-        <h2 id="elements-transverses" class="fr-h3 fr-mb-2w page-title">
+        <h2
+          id="improvements_elements-transverses"
+          class="fr-h3 fr-mb-2w page-title"
+        >
           Éléments transverses
         </h2>
 
@@ -65,7 +69,7 @@ const improvementsCount = computed(() => {
         :key="page.id"
         class="fr-mb-8w"
       >
-        <h2 :id="`${page.id}`" class="fr-h3 fr-mb-2w page-title">
+        <h2 :id="`improvements_${page.id}`" class="fr-h3 fr-mb-2w page-title">
           {{ page.name }}
         </h2>
         <a