From e3b6b529c06da4f2c8bd4b5080c4ffe585885a08 Mon Sep 17 00:00:00 2001
From: Adrien Boutigny <adrien@slash-tmp.dev>
Date: Fri, 22 Nov 2024 10:57:09 +0100
Subject: [PATCH] =?UTF-8?q?Corrige=20la=20mise=20=C3=A0=20jour=20des=20par?=
 =?UTF-8?q?am=C3=A8tres=20de=20l'audit=20(#875)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix store data objects being referenced instead of cloned in forms components

* update changelog

---------

Co-authored-by: Quentin Bellanger <hello@quentin-bellanger.com>
---
 CHANGELOG.md                                                | 6 ++++++
 .../src/components/audit/AuditSettingsForm.vue              | 4 ++--
 confiture-web-app/src/pages/audit/AuditDeclarationPage.vue  | 6 +++---
 confiture-web-app/src/store/results.ts                      | 6 +++---
 4 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index eb68cd73..53ae9957 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 Tous les changements notables de Ara sont documentés ici avec leur date, leur catégorie (nouvelle fonctionnalité, correction de bug ou autre changement) et leur pull request (PR) associée.
 
+## 22/11/2024
+
+### Corrections 🐛
+
+- Corrige la "fausse" mise à jour des paramètres de l’audit quand on quitte la page sans sauvegarder ([#875](https://github.com/DISIC/Ara/pull/875))
+
 ## 21/11/2024
 
 ### Corrections 🐛
diff --git a/confiture-web-app/src/components/audit/AuditSettingsForm.vue b/confiture-web-app/src/components/audit/AuditSettingsForm.vue
index 56da6be4..bf93e12c 100644
--- a/confiture-web-app/src/components/audit/AuditSettingsForm.vue
+++ b/confiture-web-app/src/components/audit/AuditSettingsForm.vue
@@ -1,5 +1,5 @@
 <script lang="ts" setup>
-import { nextTick, ref, watch } from "vue";
+import { nextTick, ref, toRaw, watch } from "vue";
 import { useRoute } from "vue-router";
 
 import { useAccountStore } from "../../store/account";
@@ -62,7 +62,7 @@ const accountStore = useAccountStore();
 
 const auditType = ref(props.audit?.auditType);
 const procedureName = ref(props.audit?.procedureName);
-const pages = ref(props.audit?.pages);
+const pages = ref(structuredClone(toRaw(props.audit?.pages)));
 const auditorEmail = ref(props.audit?.auditorEmail);
 const auditorName = ref(props.audit?.auditorName ?? "");
 
diff --git a/confiture-web-app/src/pages/audit/AuditDeclarationPage.vue b/confiture-web-app/src/pages/audit/AuditDeclarationPage.vue
index 2b26b9c1..43a54d24 100644
--- a/confiture-web-app/src/pages/audit/AuditDeclarationPage.vue
+++ b/confiture-web-app/src/pages/audit/AuditDeclarationPage.vue
@@ -1,5 +1,5 @@
 <script lang="ts" setup>
-import { computed, nextTick, ref, watch } from "vue";
+import { computed, nextTick, ref, toRaw, watch } from "vue";
 import { useRoute, useRouter } from "vue-router";
 
 import TestEnvironmentSelection from "../../components/audit/TestEnvironmentSelection/TestEnvironmentSelection.vue";
@@ -144,7 +144,7 @@ watch(
     contactFormUrl.value = audit.contactFormUrl ?? "";
 
     validatedTechnologies.value = audit.technologies.length
-      ? audit.technologies
+      ? structuredClone(toRaw(audit.technologies))
       : [];
 
     defaultTools.value = audit.tools.length
@@ -155,7 +155,7 @@ watch(
       ? audit.tools.filter((tool) => !availableTools.includes(tool))
       : [];
 
-    environments.value = audit.environments ?? [];
+    environments.value = structuredClone(toRaw(audit.environments)) ?? [];
 
     notCompliantContent.value = audit.notCompliantContent ?? "";
     derogatedContent.value = audit.derogatedContent ?? "";
diff --git a/confiture-web-app/src/store/results.ts b/confiture-web-app/src/store/results.ts
index 709064eb..eff50d44 100644
--- a/confiture-web-app/src/store/results.ts
+++ b/confiture-web-app/src/store/results.ts
@@ -122,10 +122,10 @@ export const useResultsStore = defineStore("results", {
       const transversePageId =
         auditStore.currentAudit?.transverseElementsPage.id;
 
-      return (
-        !this.allResults
+      return !(
+        this.allResults
           ?.filter((r) => r.pageId !== transversePageId)
-          .some((r) => r.status === CriteriumResultStatus.NOT_TESTED) ?? false
+          .some((r) => r.status === CriteriumResultStatus.NOT_TESTED) ?? true
       );
     },