Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannon Cove score counter doesn't show personal/friends best scores to beat #1710

Open
3 tasks done
BrieFlory opened this issue Jan 1, 2025 · 1 comment · May be fixed by #1719
Open
3 tasks done

BUG: Cannon Cove score counter doesn't show personal/friends best scores to beat #1710

BrieFlory opened this issue Jan 1, 2025 · 1 comment · May be fixed by #1719
Labels
bug Something isn't working P-Fixer This issue is confirmed, but is not prioritized to be fixed.

Comments

@BrieFlory
Copy link

Make sure you've done the following:

  • I have checked that this issue has not already been reported.

  • I have validated that this issue is not a syntax error of either MySQL or SQLite.

  • I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.

DarkflameServer Version

latest

Issue Description

In live the game would seemingly pick between your own best score or a friend's best score as a target to beat instead of just showing progress towards Hearty Score forever.

The logic for this seems similar to how it's handled in AGS though it may be different?

https://youtu.be/xilmSHk8oq8?si=U_1l09NYFQ1jnqDA&t=470

Reproduction Steps

Play Cannon cove at least once to establish a personal best
Replay Cannon cove
Note that the goal shown is still for Hearty Score 1/2/3/4

Expected Behavior

Either a personal best or friend's score should be shown

Environment

Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment)))))))))))))))))))

@BrieFlory BrieFlory added bug Something isn't working triage An issue that needs triage labels Jan 1, 2025
@EmosewaMC
Copy link
Collaborator

because the person who wrote the leaderboard checkgm mistook leaderboard type for leaderboard size

@EmosewaMC EmosewaMC added P-Fixer This issue is confirmed, but is not prioritized to be fixed. and removed triage An issue that needs triage labels Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P-Fixer This issue is confirmed, but is not prioritized to be fixed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants