Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The WebView com.delphiworlds.kastri.DWWebViewClient does not check TLS certificate validity correctly #268

Open
MahindiBoiro opened this issue Nov 26, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@MahindiBoiro
Copy link

We passed our app that contains code from kastri through an online tool for static app analysis (https://appsweep.guardsquare.com) and the above issue was identified alongside the details below:

Your app contains the custom WebView com.delphiworlds.kastri.DWWebViewClient which incorrectly implements TLS error handling. The overridden onReceivedSslError method does not contain any call to handler.cancel().

Therefore, when this WebView is shown, invalid TLS certificates will be accepted.

An attacker who is able to intercept the connection (e.g. with a man-in-the-middle (MitM) attack), can eavesdrop and modify the communication arbitrarily. At worst, if the WebView receives code from your backend, an attacker can modify it and gain remote code execution on the users’ device.

@DelphiWorlds DelphiWorlds self-assigned this Nov 26, 2024
@DelphiWorlds DelphiWorlds added the bug Something isn't working label Nov 26, 2024
@DelphiWorlds
Copy link
Owner

Pushed a fix to the Java source and rebuilt dw-kastri-base-3.0.0.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants