Error when opening saved model

[SCLaan]

Severity Level

Medium

Steps to reproduce

1. Generate a model, going through all steps in the Model Maker tab
2. Optionally build the model
3. Save the model
4. Select working directory
5. Load sfincs.inp

Current behaviour

I get no user feedback in the GUI and see the error below in my terminal. Note that it is the same error twice, first when setting the working directory and afterwards when loading the .inp.

Map is ready
Traceback (most recent call last):
  File "C:\Users\laan_st\.conda\envs\ddb_floodadapt\Lib\site-packages\guitares\pyqt5\menu.py", line 21, in menu_item_selected
    callback(option)
  File "C:\Users\laan_st\OneDrive - Stichting Deltares\Documents\GitHub\DelftDashboard\src\delftdashboard\menu\file.py", line 49, in open
    app.active_model.open()
  File "C:\Users\laan_st\OneDrive - Stichting Deltares\Documents\GitHub\DelftDashboard\src\delftdashboard\models\sfincs_hmt\sfincs_hmt.py", line 278, in open
    root = os.path.dirname(fname)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen ntpath>", line 251, in dirname
  File "<frozen ntpath>", line 213, in split
TypeError: expected str, bytes or os.PathLike object, not tuple
No method select_working_directory for model:  fiat
Traceback (most recent call last):
  File "C:\Users\laan_st\.conda\envs\ddb_floodadapt\Lib\site-packages\guitares\pyqt5\menu.py", line 21, in menu_item_selected
    callback(option)
  File "C:\Users\laan_st\OneDrive - Stichting Deltares\Documents\GitHub\DelftDashboard\src\delftdashboard\menu\file.py", line 49, in open
    app.active_model.open()
  File "C:\Users\laan_st\OneDrive - Stichting Deltares\Documents\GitHub\DelftDashboard\src\delftdashboard\models\sfincs_hmt\sfincs_hmt.py", line 278, in open
    root = os.path.dirname(fname)
           ^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen ntpath>", line 251, in dirname
  File "<frozen ntpath>", line 213, in split
TypeError: expected str, bytes or os.PathLike object, not tuple

Note that fiat is mentioned in the error. However, I am trying to load a SFINCS model here. Maybe it is looking for the wrong file?

Desired behaviour

Should this work, or is Open only inteded for models that have been built?
In any case, there should be some user feedback in the GUI when this doesn't work.

Additional context

I'm using the latest version of DelftDashboard (branch: FloodAdapt_ModelBuilders, commit: f91f5f2)

[roeldegoede]

Yep, this partly links to #102 . Didn't work yet on reading in the entire model, but that is high on my list. The FIAT errorsare due to an erronuous commit, so we have to fix this.