Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include units for input fields #109

Open
SCLaan opened this issue Feb 22, 2024 · 1 comment
Open

Include units for input fields #109

SCLaan opened this issue Feb 22, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@SCLaan
Copy link
Collaborator

SCLaan commented Feb 22, 2024

Kind of issue

Docs are missing

Location of the documentation

SFINCS model builder, under Boundary Conditions > Water levels > Add timeseries

Documentation problem

No units are displayed for the Constant water level. I assume this is in meters:
image

Suggested fix for documentation

To avoid confusion for US users - they might assume feet isntead of meters - I would suggest to display the units in the support text.
@SCLaan SCLaan added the documentation Improvements or additions to documentation label Feb 22, 2024
@roeldegoede
Copy link
Collaborator

Good one, it does look a bit different already, but we should add the units yes. Ideally that is something we can configure somewhere (feet, m wrt certain reference level).

image

roeldegoede added a commit that referenced this issue Feb 28, 2024
@roeldegoede
fixes for #109 (, #110) and #117
198e352
@roeldegoede roeldegoede mentioned this issue Feb 28, 2024
Merged
roeldegoede added a commit that referenced this issue Mar 8, 2024
@roeldegoede
Improved functionality of boundary conditions (#120)
8820cf8 
Fixed:
- #109 units are added for water levels (m+Ref) and discharge (m3/s).
Not ideal (maybe we would like to configure this somewhere instead of
hardcoding?), but a good starting point.
- #117 guassian shaped timeseries can be added (and copied to all
points)
- improved a bit on stuff discussed in #110 

Also added:
- enabled downloading from NOAA waterlevels from API
- enabled loading geojsons and shapefiles (both for discharge and
waterlevels)
- added the guassian shaped option for discharges as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SCLaan @roeldegoede