Crash when adding discharge boundary conditions

[SCLaan]

Severity Level

High

Steps to reproduce

1. Build a simple model (for a watershed) with:
   • an automatic zoom level (clicking Cancel)
   • automatically generated water level boundary points
2. Go to Boundary Conditions and click on the tab Discharge (gives a first error)
3. Click on Add Point (gives second (minor) error)
4. Click somewhere on the model domain (gives third error and the GUI crashes)

Current behaviour

Error at step 2:

Traceback (most recent call last):
  File "C:\Users\laan_st\.conda\envs\ddb_floodadapt\Lib\site-packages\guitares\pyqt5\tabpanel.py", line 31, in tab_selected
    tabs[indx].module.select()
  File "c:\Users\laan_st\OneDrive - Stichting Deltares\Documents\GitHub\DelftDashboard\src\delftdashboard\models\sfincs_hmt\boundary_conditions_dis.py", line 12, in select
    app.map.layer["sfincs_hmt"].layer["discharge_points"].activate()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
KeyError: 'discharge_points'
can only concatenate str (not "NoneType") to str
javaScriptConsoleMessage:  2 Uncaught (in promise) TypeError: Failed to fetch dynamically imported module: http://localhost:3000/js/geojson_layer_line.js 0 http://localhost:3000/

Error at step 3:
can only concatenate str (not "NoneType") to str

Error at step 4:

127.0.0.1 - - [22/Feb/2024 14:21:54] "GET /overlays/sfincs_hmt.bed_levels.png HTTP/1.1" 200 -
127.0.0.1 - - [22/Feb/2024 14:21:54] "GET /overlays/sfincs_hmt.bed_levels.legend.373737.png HTTP/1.1" 200 -
Error loading ddb background topo ...
Traceback (most recent call last):
  File "C:\Users\laan_st\.conda\envs\ddb_floodadapt\Lib\site-packages\guitares\pyqt5\mapbox\mapbox.py", line 153, in pointClicked
    self.point_clicked_callback(x, y)
  File "c:\Users\laan_st\OneDrive - Stichting Deltares\Documents\GitHub\DelftDashboard\src\delftdashboard\models\sfincs_hmt\boundary_conditions_dis.py", line 61, in point_clicked
    app.map.layer["sfincs_hmt"].layer["discharge_points"].set_data(gdf, index)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
KeyError: 'discharge_points'

After this error the GUI crashes.

Desired behaviour

This should work correctly or give me a warning message explaining what my mistake is.

Additional context

I'm using the latest version of DelftDashboard (branch: FloodAdapt_ModelBuilders, commit: f91f5f2)

[roeldegoede]

Addings points already worked in the open PR which is now also merged 02fe3a9

I see that I already did something with units there. However, I also found out that is still a bit buggy (so needs some love).