Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[This is a bug] "Build model" crashes during "Writing tiles" #116

Open
1 task done
laurscham opened this issue Feb 23, 2024 · 3 comments
Open
1 task done

[This is a bug] "Build model" crashes during "Writing tiles" #116

laurscham opened this issue Feb 23, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@laurscham
Copy link
Collaborator

Preliminary Checklist

  • I have searched the existing issues list for similar requests and found none. If you did find a similar requests, please add a comment to the existing requests instead of opening a new one.

Kind of request

None

Enhancement Description

FloodAdapt Model Builder, "Model Maker" tab, "Build Model"

After clicking "build model" a window pops up asking me to specifiy tiles (0-20). 1) It is not obvious what this means, 2) I chose 5 because it is within the range stated, and the GUI hangs here with a "TypeError"in the log:

image

image

Task list

No response

Use case

No response

Additional Context

No response

@laurscham laurscham added enhancement New feature or request question Further information is requested bug Something isn't working and removed enhancement New feature or request question Further information is requested labels Feb 23, 2024
@laurscham
Copy link
Collaborator Author

If I select "0" instead of "5" it works without any problems

@roeldegoede
Copy link
Collaborator

Thanks for this feedback! I agree that the generating tiles is not very clear and that this needs some additional documentation.

In short, these tiles are needed for visualization of the model in the FloodAdapt-GUI or webviewers. The zoom-level you need the specify determines the highest-resolution of your "downscaled" floodmaps. This step can be somewhat time-consuming therefore I made the zoom-level optional (you skip it by pressing cancel) and configurable (the higher your zoom-level, the longer it takes). @kathrynroscoe let's think about a proper alternative.

Regarding the error, that is new to me (but I can reproduce), so I'll try to fix that.

@roeldegoede
Copy link
Collaborator

I proposed a proper fix (for the real bug) in hydromt: Deltares/hydromt#801

However, I also implemented a workaround in our GUI: #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants