Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[This is a bug] "Add"-ing Peak water level value in "Boundary Conditions" tab doesn't work for Synthetic timeseries #117

Open
1 task done
laurscham opened this issue Feb 23, 2024 · 1 comment
Open
1 task done

[This is a bug] "Add"-ing Peak water level value in "Boundary Conditions" tab doesn't work for Synthetic timeseries #117

laurscham opened this issue Feb 23, 2024 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@laurscham
Copy link
Collaborator

Preliminary Checklist

  • I have searched the existing issues list for similar requests and found none. If you did find a similar requests, please add a comment to the existing requests instead of opening a new one.

Kind of request

None

Enhancement Description

Flood Adapt Model Builder - SFINCS - Boundary conditions tab - Water levels subtab

Choosing a "Synthetic" time series, editing the peak water level value and choosing "Add", then selecting a different point, and going back to the original point, shows "0" instead of the value you added.

"Copy to all points" also does not work for the "Synthetic" time series.

Task list

No response

Use case

No response

Additional Context

No response
@laurscham laurscham added enhancement New feature or request question Further information is requested labels Feb 23, 2024
roeldegoede added a commit that referenced this issue Feb 28, 2024
@roeldegoede
fixes for #109 (, #110) and #117
198e352
@roeldegoede roeldegoede mentioned this issue Feb 28, 2024
Merged
@roeldegoede
Copy link
Collaborator

Thanks for bringing this to my attention. For me the copy to all points works flawless; however, I noticed that the timeseries that was generated didn't fit my expectations (peak in the middle), and actually the peak water levels werent reached (I forgot brackets in the formulations).

I fixed this in: #120

Could you give it a try again?

roeldegoede added a commit that referenced this issue Mar 8, 2024
@roeldegoede
Improved functionality of boundary conditions (#120)
8820cf8 
Fixed:
- #109 units are added for water levels (m+Ref) and discharge (m3/s).
Not ideal (maybe we would like to configure this somewhere instead of
hardcoding?), but a good starting point.
- #117 guassian shaped timeseries can be added (and copied to all
points)
- improved a bit on stuff discussed in #110 

Also added:
- enabled downloading from NOAA waterlevels from API
- enabled loading geojsons and shapefiles (both for discharge and
waterlevels)
- added the guassian shaped option for discharges as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roeldegoede @laurscham