Some SFINCS models cannot be used to define the domain for Delft-FIAT model builder (missing region.geojsn file)

[kathrynroscoe]

Preliminary Checklist

• I have searched the existing issues list for similar reports and found none. If you did find a similar issue, please add a comment to the existing issue instead of opening a new one.
• I have verified that the issue exists in the latest version of DelftDashboard and its dependencies. Please update to the latest version and check if the issue still exists.

Severity Level

Medium

Steps to reproduce

In the Delft-FIAT model-builder, choose SFINCS model for your model domain and then select a SFINCS model folder that was built either (1) before hydromt-sfincs made the region.geojsn file or (2) was not created with hydromt-sfincs. It will not load the domain because it cannot find the region.geojsn file.

Current behaviour

Older SFINCS models or those not built with hydromt-sfincs cannot be used to define the Delft-FIAT model domain

Desired behaviour

When you choose an older SFINCS models or one not built with hydromt-sfincs, it will use the existing SFINCS files to generate a region.geojsn file, and then use this for the Delft-FIAT model domain.

Additional context

No response

[GundulaW]

Three simple lines of code to get the model region immediately from a SFINCS model:

from hydromt_sfincs import SfincsModel
sf_model = SfincsModel(root=model_root, mode="r+")
sf_model.region