Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExtOldForcing does not have a validator for filetype #753

Open
MAfarrag opened this issue Feb 27, 2025 · 0 comments
Open

ExtOldForcing does not have a validator for filetype #753

MAfarrag opened this issue Feb 27, 2025 · 0 comments
Labels
extforce external forcing file conversion type: bug Something isn't working

Comments

@MAfarrag
Copy link
Contributor

Describe the bug

  • The ExtOldForcing does not have a validator for the filetype parameter.
  • The filetype parameter is used in a root validator to choose the right class for the file (DiskOnlyFileModel, PolyFile, TimModel), and wrong filetype will crash the converter to the new external forcing format.

Expected behavior
a field validator to check the given value for the filetype parameter is within the possible values.

Version info (please complete the following information):

  • Version 0.8.1
@MAfarrag MAfarrag added type: bug Something isn't working extforce external forcing file conversion labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extforce external forcing file conversion type: bug Something isn't working
Projects
HYDROLIB-core
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MAfarrag