Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider using Configurations.jl for Config handling #243

Open
Tracked by #351
visr opened this issue Feb 17, 2023 · 6 comments · May be fixed by #519
Open
Tracked by #351

consider using Configurations.jl for Config handling #243

visr opened this issue Feb 17, 2023 · 6 comments · May be fixed by #519
Assignees
@JoostBuitink @SouthEndMusic
Labels
user-experience Improvements to the settings file, logging, error handling, etc. v1.0 Activities related to v1.0
Milestone
2024 - Q2

Comments

@visr
Copy link
Member

visr commented Feb 17, 2023

In Deltares/Ribasim#66 @evetion improved the TOML config handling, which includes some validation. It is worth considersing using a similar approach in Wflow. This could simplify code and catch user errors earlier.

Currently we create our own struct, and overload a bunch of functions to have things like config.option work:

https://github.com/Deltares/Wflow.jl/blob/v0.6.2/src/io.jl#L36-L39

That could be turned into something like this:

https://github.com/Deltares/Ribasim.jl/blob/3c8f9c48fae613e1e45d3dfffc97e861a95324a6/src/config.jl#L32-L59
@visr visr mentioned this issue Feb 17, 2023
Merged
@verseve
Copy link
Contributor

verseve commented Feb 20, 2023

Thanks for sharing! Seems indeed quite nice, we will look into this.

@evetion
Copy link
Member

evetion commented Feb 20, 2023

If it has no priority, I can look into it in a month or two.

@verseve
Copy link
Contributor

verseve commented Apr 3, 2023

Indeed this issue has no priority, so great if you can look into this!

@JoostBuitink JoostBuitink added the user-experience Improvements to the settings file, logging, error handling, etc. label Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 🔲 Todo in Wflow Apr 17, 2023
@verseve
Copy link
Contributor

verseve commented Jun 7, 2023

Hi @evetion, do you have time to look into this? If not, @JoostBuitink has interest to look into this issue (with some guidance/help from your side).

@evetion
Copy link
Member

evetion commented Jun 7, 2023

@JoostBuitink Feel free to pick it up, let me know if there are questions.

@alimeshgi alimeshgi added the v1.0 Activities related to v1.0 label Feb 9, 2024
@JoostBuitink JoostBuitink mentioned this issue Mar 21, 2024
Open
6 tasks
@alimeshgi alimeshgi added this to the 2024 - Q2 milestone Mar 21, 2024
@JoostBuitink
Copy link
Contributor

see main issue #351

@SouthEndMusic SouthEndMusic self-assigned this Dec 10, 2024
@SouthEndMusic SouthEndMusic linked a pull request Dec 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoostBuitink JoostBuitink

@SouthEndMusic SouthEndMusic

Labels
user-experience Improvements to the settings file, logging, error handling, etc. v1.0 Activities related to v1.0
Projects
No open projects
Wflow
Status: 🔲 Todo
Milestone
2024 - Q2
Development

Successfully merging a pull request may close this issue.

Use Configurations.jl for configuration Deltares/Wflow.jl
6 participants
@visr @evetion @verseve @JoostBuitink @SouthEndMusic @alimeshgi