Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: finish mobile scren for track details page #42

Merged
merged 8 commits into from
Dec 2, 2023

Conversation

recepcankaya
Copy link
Collaborator

Changes

  • Mobile version of track details page finished
  • Header changed and renamed it as navbar
  • Footer is adjusted to mobile

API Updates

  • Collapsible component from shadcn was added through manual copy-paste

#39
#40

Copy link

vercel bot commented Nov 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 0:51am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 0:51am

@Markkos89
Copy link
Collaborator

@recepcankaya can you update this branch with main latests version?

Copy link

github-actions bot commented Nov 16, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 33
🟢 Accessibility 95
🟠 Best practices 75
🟢 SEO 92
🟢 PWA 100

Lighthouse ran on https://academy-turbo-git-feat-track-details-page-developdao.vercel.app/

@recepcankaya
Copy link
Collaborator Author

With the latest commit, I updated the code as recommended by @Markkos89

  • Made changes for navbar, track-details page and footer

@recepcankaya
Copy link
Collaborator Author

For feat: finish the desktop version of track-details page commit:

Changes

  • Desktop version of track details page is finished. Later, it will be updated for the every screen will be made full responsive
  • Toggle image is added onto header
  • Even though it does not show very well, the images which are below are a clue of what it looks like in the desktop

image
image
image

Copy link
Collaborator

@Markkos89 Markkos89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to go @recepcankaya

if we see details after this we can fix them in later PRs 😉

thanks a lot for your hard work!

🚀

@recepcankaya recepcankaya merged commit eb102ba into main Dec 2, 2023
3 checks passed
@Markkos89 Markkos89 deleted the feat/track-details-page branch January 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants