Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: track details page #43

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Refactor: track details page #43

merged 3 commits into from
Nov 30, 2023

Conversation

Markkos89
Copy link
Collaborator

@Markkos89 Markkos89 commented Nov 23, 2023 •
edited
Loading

Changes

  • changed header component on layout instead of navbar
  • enhanced topbar against BackButton behaviour when on track details page
  • track details page with hardcoded dynamic routing
  • changed hamburguer menu position for mobile view on header
  • added sidebar close action when clicking menu option with SheetClose component from shadcn ui

@Markkos89 Markkos89 added enhancement New feature or request WIP PR work in progress labels Nov 23, 2023
@Markkos89 Markkos89 self-assigned this Nov 23, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 9:13pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
academy-turbo ⬜️ Ignored (Inspect) Visit Preview Nov 23, 2023 9:13pm

@Markkos89 Markkos89 changed the base branch from main to feat/track-details-page November 23, 2023 19:58
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 12
🟢 Accessibility 100
🟠 Best practices 83
🟠 SEO 83
🔴 PWA 33

Lighthouse ran on https://academy-turbo-storybook-git-feat-track-detail-fed23c-developdao.vercel.app/

@Markkos89 Markkos89 added important and removed WIP PR work in progress labels Nov 23, 2023
@Markkos89
Copy link
Collaborator Author

@recepcankaya could you review this update to your actual PR?

Let me know if any questions or thoughts of course. I'm open to ideas.

@peteruche21 if you find some time to review it also it would be great 👌

Thanks guys! 🙌

recepcankaya
recepcankaya approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@recepcankaya recepcankaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fine. I will use Header instead of NavBar, in my project too.

@Markkos89 Markkos89 merged commit 4c75e58 into feat/track-details-page Nov 30, 2023
1 check passed
@Markkos89 Markkos89 deleted the feat/track-details-page-refactor branch January 16, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recepcankaya recepcankaya recepcankaya approved these changes

@code-z2 code-z2 Awaiting requested review from code-z2

Assignees

@Markkos89 Markkos89

Labels
enhancement New feature or request important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Markkos89 @recepcankaya