Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Categories Model #45

Open
AndrewMusgrave opened this issue Nov 6, 2017 · 5 comments
Open

Implement Categories Model #45

AndrewMusgrave opened this issue Nov 6, 2017 · 5 comments

Comments

@AndrewMusgrave
Copy link
Contributor

#29 References categories although a model has not been created. I don't see another issue open regarding this, but please let me know if there is.

I'll handling this while creating the rest endpoint.

@KenavR
Copy link
Member

KenavR commented Nov 6, 2017

Thank you, I hope I find time tomorrow to merge your PR and specify the models. If not, definitely on Wednesday.

@ozgunbal
Copy link
Contributor

In current implementation, categories is set as unique. According to #6, it should not be. Is it logically okey to be unique? Movie and series have a category/genre attribute, can be still unique with that condition?

@AndrewMusgrave
Copy link
Contributor Author

Movies and series should be able to reference the category, removing the need to have more than one of a given category.

@KenavR
Copy link
Member

KenavR commented Nov 15, 2017

Ups, I thought I answered yesterday, that was my mistake in the model, it should be unique.

@AndrewMusgrave
Copy link
Contributor Author

Added description to the model I created in my last PR to match #6 . So this issue should be solved with my latest PR #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants