Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to change the toggle key #24

Closed
vutran opened this issue Sep 1, 2016 · 2 comments
Closed

Add ability to change the toggle key #24

vutran opened this issue Sep 1, 2016 · 2 comments

Comments

@vutran
Copy link
Member

vutran commented Sep 1, 2016

Sometimes you already have cmd + space already registered to another app. Allow a way for the user to change their key bindings to another combination.

@adnasa
Copy link
Member

adnasa commented Sep 3, 2016

Would this be pure configuration (as in config on file-format) or are you considering a preference menu (like every other app out there)? 😉

@vutran
Copy link
Member Author

vutran commented Sep 3, 2016

I'm open to both options. A preference window would probably make more sense if we want to target non-developers. If it's preference window, I was considering using my react-jsonschema to scaffold the forms but don't want the material-ui that comes with it.

See #28 for more reference on managing prefs/configs.

@vutran vutran changed the title configuration toggle key Add ability to change the toggle key Sep 3, 2016
@vutran vutran closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants