Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edges with no event at top cannot be selected/do not show time #21

Closed
bestchai opened this issue May 27, 2020 · 0 comments
Closed

Edges with no event at top cannot be selected/do not show time #21

bestchai opened this issue May 27, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bestchai
Copy link
Member

bestchai commented May 27, 2020

Currently one can only interact with lines between two events. But, we should enable this interaction for lines that have no event at the start, and just count from 0 for the entire trace. So, it should be possible to select the edge above the first grey thread event below:

first-event-edge-interact.png

[Issue created by bestchai: 2016-08-04]
[Last updated on bitbucket: 2016-08-22]

[Comment created by bestchai: 2016-08-09]
The edge can be clicked, but it's not computing the right time value -- I'm only seeing 0 as the time delta for that edge. The value should be simply the time at which the event occurred (on the edge being clicked) relative to the very first event in the log

[Comment created by bestchai: 2016-08-09]
re-opening because time is not being computed properly

[Comment created by harjeetlalh: 2016-08-08]
This fixes issue #11 also handles the edge click.

→ <<cset 3539b5b>>

[Comment created by harjeetlalh: 2016-08-08]
Fixes issue #11

→ <<cset 3ec29b4>>

[Comment created by harjeetlalh: 2016-08-08]
Wait forgot to handle edge click.

[Comment created by harjeetlalh: 2016-08-22]
Fixes issue #11.

→ <<cset 97123ce>>

@bestchai bestchai added the bug Something isn't working label May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant