Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Hardcoded Values and Dead Code Smells in checkBuyableRc, checkSellableRc, and getCoinBudgets #132

Open
Tanya-ruby opened this issue Oct 3, 2024 · 5 comments
Labels
good first issue Good for newcomers

Comments

@Tanya-ruby
Copy link
Contributor

The functions checkBuyableRc and checkSellableRc currently return hardcoded values that automatically approve transactions, which should not be the case. Additionally, the getCoinBudgets function is returning hardcoded null values. These hardcoded values need to be either removed or commented out to ensure the correct logic is implemented.

Furthermore, these hardcoded values introduce dead code smells, as they do not contribute meaningfully to the program's functionality. Keeping such code can increase complexity and reduce maintainability. Removing or refactoring these sections will improve code quality and readability.

@pavanydg
Copy link

@Tanya-ruby is this issue open for contributors?

@Tanya-ruby
Copy link
Contributor Author

@pavanydg sure go ahead and make a PR ,make sure there aren't any issues created with the PR made and test it locally as well

@Tanya-ruby
Copy link
Contributor Author

@pavanydg if it is too complicated to understand ,you can go ahead and for now just comment out the two functions , checkBuyableRc and checkSellableRc

@ceilican ceilican added the good first issue Good for newcomers label Jan 12, 2025
@ceilican
Copy link
Contributor

@pavanydg , what is your discord username in our server? Could you reach out to me or Tanya there?

@pavanydg
Copy link

@ceilican i have sent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants