Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to the latest lesscss.js #27

Open
laughingwithu opened this issue Jan 2, 2012 · 7 comments
Open

updating to the latest lesscss.js #27

laughingwithu opened this issue Jan 2, 2012 · 7 comments

Comments

@laughingwithu
Copy link

Was just wondering if it would be possible for the this file to be updated to the latest one. My javascript is not the greatest or i would do it myself. It just solves a lot of issues. The biggest for me was relative urls and Flaw{Less} works perfectly with less-1.1.5.js (I have already updated it so that it loads it, just could not work out the custom flawless functions).

Thanks

@laughingwithu
Copy link
Author

Ok, worked out how to update the files here it is updated to the latest lessjs 1.1.16. This also contains quite a bit of other changes that I have made. (could not work out the forking business)

http://www.2shared.com/file/hvu-CY3M/base_flawlesscss.html

@superstructor
Copy link
Collaborator

The develop branch has 1.1.2 so would be trivial to upgrade to 1.1.5 however it is missing the custom caching etc that flawless on the master branch has. Personally I'm all for dropping any feature in flawless that requires modifying vanilla less.js as it creates all sorts of hassles such as not being able to use alternative compilers - like the command line lessc or the graphical Less.app for Macs.

Of course unfortunately without the custom caching loading so many files on every request can be painful for development.

@laughingwithu
Copy link
Author

not wanting to sound stupid, but why do you need custom caching if you are just using it for development. I have taken it all out now, initiate the function in the init.js file and it runs fast and problem free. Though i am not running this on a server as I am just going to compile the css using lessphp when i have finished.

@superstructor
Copy link
Collaborator

you'll need to use the develop branch (not the default master) of flawless if you expect it to work without custom functions. The grid calculation has been re-written on develop so that it works with vanilla less.js. Either way grid calculations will not work with either missing custom functionality or with lessphp (as it is a JS specific hack). Node's lessc, Less.app and the official less compiler are all based on less.js. Compatibility with lessphp is the goal of #13

On the subject of caching I find it slow reloading the page for testing sometimes with so many less files loading, but your right it is usable without caching. Usually it is browsers like IE8 running in a virtual machine that I have trouble with the performance.

@laughingwithu
Copy link
Author

Would you be able to point me to where the custom grid functions are so I can work it out for myself.

@laughingwithu
Copy link
Author

thanks, realise why I could not find it, since it was not in the JS files. I think rather than trying to modify the current grid system I will get http://semantic.gs/ working with flawless. It will work with less.js, less.app and I also know that it works with lessphp (except for fluid layouts). Unfortunately it won't be cross-compatible with styles already written with the flawless grid as it uses different mix-in names (though I guess I could do a file to fix that, but for my purposes I will just use a system switch variable). As for the caching I see what you mean, I prefer your branch to the master branch.

I will post what i do here, and if i can work out this forking business will try that as well.

EDIT: had a closer look - the semantic grid is a lot simpler, I am going to create a file to load the variables from .grid_setup so that it knows what to do with it. I will also do a quick commentary on whats what and what's missing/changed from the flawless grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants