We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the ApiClient::deserialize the new \DateTime($data); can potentially throw an exception, but it’s not caught in code.
ApiClient::deserialize
new \DateTime($data);
It’s also not documented in the PHPDoc that it could throw an exception, so it’s not caught anywhere throughout the code-base.
What is your protocol here? Catch the exception and give some other date(Doesn't seem like a great idea to me...) or allow the exception be thrown?
ApiClient::L443
The text was updated successfully, but these errors were encountered:
No branches or pull requests
In the
ApiClient::deserializethenew \DateTime($data);can potentially throw an exception, but it’s not caught in code.It’s also not documented in the PHPDoc that it could throw an exception, so it’s not caught anywhere throughout the code-base.
What is your protocol here? Catch the exception and give some other date(Doesn't seem like a great idea to me...) or allow the exception be thrown?
ApiClient::L443
The text was updated successfully, but these errors were encountered: