We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems we call ocn_time_average_coupled_accumulate() even in standalone runs: https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_split.F#L2665 https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_si.F#L3132 https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_si.F#L3132
ocn_time_average_coupled_accumulate()
I also don't see any evidence that there is any mechanism to bypass the computations when coupling is not enabled: https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/shared/mpas_ocn_time_average_coupled.F
The various avg* fields are allocated for all forward runs, e.g.: https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/Registry.xml#L3627-L3634
avg*
However, I could not find any evidence that ocn_time_average_coupled_init() is called in standalone runs:
ocn_time_average_coupled_init()
mpas-ocean]$ grep -r ocn_time_average_coupled_init driver/ocn_comp_mct.F: call ocn_time_average_coupled_init(forcingPool) driver/ocn_comp_mct.F: call ocn_time_average_coupled_init(forcingPool) driver/ocn_comp_mct.F: call ocn_time_average_coupled_init(forcingPool) src/shared/mpas_ocn_time_average_coupled.F:! routine ocn_time_average_coupled_init src/shared/mpas_ocn_time_average_coupled.F: subroutine ocn_time_average_coupled_init(forcingPool)!{{{ src/shared/mpas_ocn_time_average_coupled.F: end subroutine ocn_time_average_coupled_init!}}}
suggesting that the values will be garbage (and in any case will never be used).
I'm not sure this has any real consequences but it does seem kind of sloppy.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
It seems we call
ocn_time_average_coupled_accumulate()
even in standalone runs:https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_split.F#L2665
https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_si.F#L3132
https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/mode_forward/mpas_ocn_time_integration_si.F#L3132
I also don't see any evidence that there is any mechanism to bypass the computations when coupling is not enabled:
https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/shared/mpas_ocn_time_average_coupled.F
The various
avg*
fields are allocated for all forward runs, e.g.:https://github.com/E3SM-Project/E3SM/blob/master/components/mpas-ocean/src/Registry.xml#L3627-L3634
However, I could not find any evidence that
ocn_time_average_coupled_init()
is called in standalone runs:suggesting that the values will be garbage (and in any case will never be used).
I'm not sure this has any real consequences but it does seem kind of sloppy.
The text was updated successfully, but these errors were encountered: