Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the names of GenericConfig and SecretConfig #237

Open
ajeklund opened this issue Feb 24, 2023 · 0 comments
Open

Change the names of GenericConfig and SecretConfig #237

ajeklund opened this issue Feb 24, 2023 · 0 comments

Comments

@ajeklund
Copy link

As far as I can see, the GenericConfig class is intended and used only for strategy configuration objects, not all sorts of configuration objects (like SecretConfig). The GenericConfig name is hence a bit misleading, and I propose to change it to GenericStrategyConfig.

Also, it appears more natural and accurate to change the name of SecretConfig to AuthenticationConfig (since it configures an authentication process, not a secret process).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant