Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split logic from implementation #379

Open
CasperWA opened this issue Jan 12, 2024 · 0 comments
Open

Split logic from implementation #379

CasperWA opened this issue Jan 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@CasperWA
Copy link
Contributor

In order to not have to reproduce the same logic in a Python-based backend for clients, which is currently done in OTELib, it would be nice to separate out the logic that's happening in the endpoint functions to an importable library/package.

I suggest the following steps to achieve this:

  1. Separate out the logic from the endpoint functions into a separate top-module's/package's functions in this repository.
  2. Move the top-module to OTEAPI Core as a new main sub-module.

The latter should also make it possible to more easily generate testing fixtures and hooks for OTEAPI plugins directly importable from the OTEAPI Core package - a package all the plugins already depend on.

Note, this should not change the perceived functionality of the REST API.

Finally, the Python-backend in OTELib can be updated eventually, also providing no noticeable user differences in functionality here, but for both this repository as well as OTELib, the developer experience should greatly improve.

@CasperWA CasperWA added the enhancement New feature or request label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant